Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts-tasks): avoid processing export declaration types in _evaluateImport #27584

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix(scripts-tasks): avoid processing export declaration types in _evaluateImport #27584

merged 1 commit into from
Apr 18, 2023

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Apr 17, 2023 •
edited
Loading

Previous Behavior

just-scripts task lint-imports:all logic regexp is incorrectly capturing export that don't provide any module specifier. This leads into false positives as those matches are processed as part of "evaluate imports" logic.

New Behavior

export declaration matches are ignored for imports evaluation logic

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 17, 2023
@Hotell Hotell marked this pull request as ready for review April 17, 2023 09:40
@Hotell Hotell requested a review from a team as a code owner April 17, 2023 09:40
@Hotell Hotell mentioned this pull request Apr 17, 2023
Open
@size-auditor
Copy link

size-auditor bot commented Apr 17, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 27665739a1f38468c63ea1544a2e82ff357d25f3 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 17, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff84f95:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 721 719 5000
Button mount 408 407 5000
Field mount 1242 1244 5000
FluentProvider mount 780 796 5000
FluentProviderWithTheme mount 113 107 10
FluentProviderWithTheme virtual-rerender 88 90 10
FluentProviderWithTheme virtual-rerender-with-unmount 102 101 10
InfoButton mount 14 21 5000
MakeStyles mount 1196 1213 50000
Persona mount 1939 1884 5000
SpinButton mount 1494 1499 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
priority-overflow
createOverflowManager		 3.194 kB
1.314 kB
react-accordion
Accordion (including children components)		 88.978 kB
26.586 kB
react-alert
Alert		 96.657 kB
23.331 kB
react-avatar
Avatar		 59.542 kB
15.569 kB
react-avatar
AvatarGroup		 18.19 kB
6.706 kB
react-avatar
AvatarGroupItem		 75.803 kB
20.072 kB
react-badge
Badge		 26.075 kB
7.629 kB
react-badge
CounterBadge		 27.058 kB
7.938 kB
react-badge
PresenceBadge		 34.547 kB
8.726 kB
react-button
Button		 39.845 kB
10 kB
react-button
CompoundButton		 47.017 kB
11.469 kB
react-button
MenuButton		 44.532 kB
11.352 kB
react-button
SplitButton		 53.027 kB
12.914 kB
react-button
ToggleButton		 58.217 kB
11.922 kB
react-card
Card - All		 86.164 kB
24.342 kB
react-card
Card		 80.983 kB
22.881 kB
react-card
CardFooter		 9.122 kB
3.832 kB
react-card
CardHeader		 11.048 kB
4.537 kB
react-card
CardPreview		 9.927 kB
4.18 kB
react-checkbox
Checkbox		 37.109 kB
11.286 kB
react-combobox
Combobox (including child components)		 89.878 kB
28.552 kB
react-combobox
Dropdown (including child components)		 88.562 kB
28.275 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 68.803 kB
18.728 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 208.156 kB
57.857 kB
react-components
react-components: FluentProvider & webLightTheme		 38.886 kB
12.41 kB
react-datepicker-compat
DatePicker Compat		 252.153 kB
67.645 kB
react-dialog
Dialog (including children components)		 93.413 kB
27.46 kB
react-divider
Divider		 19.958 kB
6.736 kB
react-field
Field		 21.589 kB
7.453 kB
react-image
Image		 14.023 kB
5.008 kB
react-infobutton
InfoButton		 131.476 kB
39.787 kB
react-infobutton
InfoLabel		 134.77 kB
40.807 kB
react-input
Input		 26.796 kB
8.148 kB
react-label
Label		 12.657 kB
4.618 kB
react-link
Link		 12.313 kB
5.081 kB
react-menu
Menu (including children components)		 131.181 kB
39.744 kB
react-menu
Menu (including selectable components)		 134.187 kB
40.281 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 66.568 kB
17.513 kB
react-popover
Popover		 117.751 kB
35.885 kB
react-portal
Portal		 11.649 kB
4.263 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.185 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 16.409 kB
5.855 kB
react-provider
FluentProvider		 20.833 kB
7.177 kB
react-radio
Radio		 29.921 kB
9.118 kB
react-radio
RadioGroup		 13.952 kB
5.163 kB
react-select
Select		 28.004 kB
9.223 kB
react-slider
Slider		 36.934 kB
11.514 kB
react-spinbutton
SpinButton		 36.705 kB
10.792 kB
react-spinner
Spinner		 23.515 kB
7.226 kB
react-switch
Switch		 32.528 kB
9.73 kB
react-table
DataGrid		 151.536 kB
41.299 kB
react-table
Table (Primitives only)		 47.143 kB
12.817 kB
react-table
Table as DataGrid		 134.099 kB
34.001 kB
react-table
Table (Selection only)		 82.011 kB
20.028 kB
react-table
Table (Sort only)		 81.341 kB
19.84 kB
react-text
Text - Default		 15.03 kB
5.339 kB
react-text
Text - Wrappers		 15.584 kB
5.245 kB
react-textarea
Textarea		 30.203 kB
9.519 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.33 kB
6.764 kB
react-theme
Teams: Light theme		 17.895 kB
5.162 kB
react-tooltip
Tooltip		 49.478 kB
16.853 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 27665739a1f38468c63ea1544a2e82ff357d25f3

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AlertMinimalPerf.default 201 194 1.04:1
ButtonMinimalPerf.default 117 113 1.04:1
InputMinimalPerf.default 664 641 1.04:1
LayoutMinimalPerf.default 284 273 1.04:1
PortalMinimalPerf.default 118 114 1.04:1
ChatDuplicateMessagesPerf.default 188 183 1.03:1
ChatWithPopoverPerf.default 239 233 1.03:1
ListWith60ListItems.default 471 459 1.03:1
BoxMinimalPerf.default 273 268 1.02:1
DividerMinimalPerf.default 277 271 1.02:1
HeaderSlotsPerf.default 626 614 1.02:1
IconMinimalPerf.default 488 477 1.02:1
TextAreaMinimalPerf.default 370 362 1.02:1
AnimationMinimalPerf.default 391 386 1.01:1
AttachmentMinimalPerf.default 104 103 1.01:1
ButtonOverridesMissPerf.default 766 761 1.01:1
CardMinimalPerf.default 403 399 1.01:1
CheckboxMinimalPerf.default 1340 1332 1.01:1
EmbedMinimalPerf.default 2056 2041 1.01:1
FlexMinimalPerf.default 217 214 1.01:1
ItemLayoutMinimalPerf.default 887 881 1.01:1
SkeletonMinimalPerf.default 275 271 1.01:1
SliderMinimalPerf.default 842 836 1.01:1
SplitButtonMinimalPerf.default 2731 2716 1.01:1
CustomToolbarPrototype.default 1821 1795 1.01:1
AttachmentSlotsPerf.default 780 782 1:1
CarouselMinimalPerf.default 315 316 1:1
ChatMinimalPerf.default 553 553 1:1
DatepickerMinimalPerf.default 4309 4300 1:1
DialogMinimalPerf.default 611 612 1:1
DropdownManyItemsPerf.default 477 476 1:1
LabelMinimalPerf.default 294 295 1:1
ListCommonPerf.default 494 492 1:1
ListNestedPerf.default 411 411 1:1
LoaderMinimalPerf.default 224 224 1:1
PopupMinimalPerf.default 475 477 1:1
ProviderMergeThemesPerf.default 846 848 1:1
ProviderMinimalPerf.default 256 255 1:1
ReactionMinimalPerf.default 294 293 1:1
SegmentMinimalPerf.default 270 269 1:1
StatusMinimalPerf.default 546 548 1:1
TableManyItemsPerf.default 1413 1406 1:1
TableMinimalPerf.default 319 319 1:1
TextMinimalPerf.default 267 266 1:1
TooltipMinimalPerf.default 1578 1571 1:1
ButtonSlotsPerf.default 370 373 0.99:1
GridMinimalPerf.default 258 260 0.99:1
HeaderMinimalPerf.default 278 281 0.99:1
ImageMinimalPerf.default 302 305 0.99:1
MenuMinimalPerf.default 638 643 0.99:1
MenuButtonMinimalPerf.default 1188 1202 0.99:1
ToolbarMinimalPerf.default 674 680 0.99:1
TreeWith60ListItems.default 107 108 0.99:1
AvatarMinimalPerf.default 140 143 0.98:1
DropdownMinimalPerf.default 1743 1772 0.98:1
ListMinimalPerf.default 403 410 0.98:1
RosterPerf.default 1619 1657 0.98:1
RadioGroupMinimalPerf.default 351 359 0.98:1
TreeMinimalPerf.default 612 624 0.98:1
FormMinimalPerf.default 282 293 0.96:1
RefMinimalPerf.default 138 145 0.95:1
VideoMinimalPerf.default 508 532 0.95:1
AccordionMinimalPerf.default 99 106 0.93:1

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2023 •
edited
Loading

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 793 771 5000
Breadcrumb mount 2079 2015 1000
Checkbox mount 2088 2097 5000
CheckboxBase mount 1852 1849 5000
ChoiceGroup mount 3548 3563 5000
ComboBox mount 807 793 1000
CommandBar mount 7758 7843 1000
ContextualMenu mount 14755 15111 1000
DefaultButton mount 933 929 5000
DetailsRow mount 2653 2661 5000
DetailsRowFast mount 2625 2678 5000
DetailsRowNoStyles mount 2421 2447 5000
Dialog mount 3230 3196 1000
DocumentCardTitle mount 292 298 1000
Dropdown mount 2438 2470 5000
FocusTrapZone mount 1395 1448 5000
FocusZone mount err 1374 5000
GroupedList mount 45888 45808 2
GroupedList virtual-rerender 22257 22253 2
GroupedList virtual-rerender-with-unmount 65294 63223 2
GroupedListV2 mount 279 291 2
GroupedListV2 virtual-rerender 264 273 2
GroupedListV2 virtual-rerender-with-unmount 289 288 2
IconButton mount 1307 1328 5000
Label mount 454 454 5000
Layer mount 3388 3415 5000
Link mount 536 528 5000
MenuButton mount 1172 1158 5000
MessageBar mount 26236 26171 5000
Nav mount 2357 2337 1000
OverflowSet mount 1009 1013 5000
Panel mount 2140 2130 1000
Persona mount 917 934 1000
Pivot mount 1063 1072 1000
PrimaryButton mount 1059 1051 5000
Rating mount 5786 5784 5000
SearchBox mount 1112 1126 5000
Shimmer mount 2324 2314 5000
Slider mount 1673 1662 5000
SpinButton mount 3409 3468 5000
Spinner mount 517 517 5000
SplitButton mount 2170 2181 5000
Stack mount 532 532 5000
StackWithIntrinsicChildren mount 1091 1097 5000
StackWithTextChildren mount 3375 3374 5000
SwatchColorPicker mount 7447 7412 5000
TagPicker mount 1752 1744 5000
Text mount 494 487 5000
TextField mount 1127 1127 5000
ThemeProvider mount 1008 1019 5000
ThemeProvider virtual-rerender 798 808 5000
ThemeProvider virtual-rerender-with-unmount 1546 1574 5000
Toggle mount 785 793 5000
buttonNative mount 244 246 5000

@Hotell Hotell enabled auto-merge (squash) April 17, 2023 12:27
@Hotell Hotell force-pushed the hotell/scripts/fix-lint-imports-invalid-exports-check branch from 98a4857 to ff84f95 Compare April 17, 2023 12:28
@Hotell Hotell disabled auto-merge April 17, 2023 14:10
@Hotell Hotell requested a review from fabricteam April 17, 2023 14:12
@Hotell Hotell closed this Apr 17, 2023
@Hotell Hotell reopened this Apr 17, 2023
@Hotell Hotell enabled auto-merge (squash) April 17, 2023 14:21
@Hotell Hotell merged commit 4c57dc7 into microsoft:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@fabricteam fabricteam Awaiting requested review from fabricteam

Assignees
No one assigned
Labels
Area: Build System Priority 1: High
Projects
None yet
Milestone
April Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @TristanWatanabe